了解 52 个卡片对象的生成

Question

我已经成功地向控制台输出了 52 个不同的“卡片”，但是我执行的检查以查看是否生成了单个对象似乎表明我在某个地方出错了。
例如，我的 num 构造函数不会随着卡片的创建而增加，而且当我使用 foreach 循环遍历列表时，卡片的值都为 13。我相信这是我将卡片添加到卡片组的地方，但我并不完全当然。

对不起，如果这是一个已经回答过的新手问题！

    {
        public int Suite 
        public int Value 
        public string cardString;
        public int num;
        public Card ()
        { num++; }

      public static void GenerateDeck()
        {
            List<Card> Deck = new List<Card>();
            for (int c = 1; c < 5; c++)
            {
                Card card = new Card();
                {
                    card.Suite = c;                   
                }
                for (int k = 1 ; k <=13; k++)
                {
                    card.Value = k;
                    {
                        switch (card.Suite)
                        {
                            case 1:
                                card.cardString = "Hearts";
                                break;
                            case 2:
                                card.cardString = "Diamonds";
                                break;
                            case 3:
                                card.cardString = "Spades";
                                break;
                            case 4:
                                card.cardString = "Clubs";
                                break;

                        }                   

                        if (card.Value == 1)
                        {
                            card.cardString = "Ace of " + card.cardString;                            
                        }
                        else if (card.Value > 0 && card.Value <= 10)
                        {
                            card.cardString = card.Value.ToString() + " of " + card.cardString;                                                      
                        }
                        else if (card.Value == 11)
                        {
                            card.cardString = "Jack of " + card.cardString;
                        }
                        else if (card.Value == 12)
                        {
                            card.cardString = "Queen of " + card.cardString;
                        }
                        else if (card.Value == 13)
                        { card.cardString = "King of " + card.cardString; }

                        Deck.Add(card);
                    }
                    Console.WriteLine(card.cardString);                  
                }
                Console.ReadLine();
            }

            foreach (var item in Deck)
            {
                Console.WriteLine("CARD SUITE {0} AND CARD VALUE {1}, num{2} ", item.Suite, item.Value, item.num                    
                    );
            }

            Console.WriteLine(Deck.Count);
            Console.ReadLine();
        }
    }
`````

Answer 1

就像 J.A.I.L 在他的回答中指出的那样，您只创建 4 个对象。

要解决您的问题，您需要为内部循环的每次迭代创建一个新的Card-object，例如：

for (int c = 1; ...)
{
    for (int k = 1; ...)
    {
        var card = new Card()
        card.Suite = c;
        card.Value = k;
        ...
     }
}

Answer 2

您只创建了 4 张新卡片：

           for (int c = 1; c < 5; c++)
            {
                Card card = new Card();
                {
                    card.Suite = c;

                }

然后，在创建这 4 辆汽车中的每一辆后，您将添加 相同的卡实例 13 次。您还将该实例的值更改 13 次，因此您最终会得到一个 Deck，其中包含 13 个相同卡片对象的实例（它们都是 Kings）：

                Card card = new Card();
                { /*...*/ } 
                for (int k = 1 ; k <=13; k++)
                {
                    card.Value = k;
                    // ... 
                    Deck.Add(card);
                }

要解决您的问题，您必须在 for "values" 循环中创建每张卡片：

           for (int c = 1; c < 5; c++)
           {
                for (int k = 1 ; k <=13; k++)
                {
                     Card card = new Card();
                     // ... Set here the Value and Suite
                 }
            }

Answer 3

创建卡片一次，在最里面的循环中；像这样的

  // Possible Suits
  string[] suits = new string[] { "Hearts", "Diamonds", "Spades", "Clubs" };

  // Possible Values: 3 groups combined
  string[] values = new string[] { "Ace" }                     // Ace
    .Concat(Enumerable.Range(2, 9).Select(c => c.ToString()))  // 2..10
    .Concat(new string[] { "Jack", "Queen", "King" })          // Jack, Queen, King
    .ToArray();

  // For each combination of Suit and value ...
  for (int suitIndex = 0; suitIndex < suits.Length; ++suitIndex)
    for (int valueIndex = 0; valueIndex < values.Length; ++valueIndex) {
      // ... we creare a card and add it to deck
      Card card = new Card() {
        Suite = suitIndex + 1,  // + 1 - since arrays are zero based
        Value = valueIndex + 1,
        cardString = $"{values[valueIndex]} of {suits[suitIndex]}"
      };

      Deck.Add(card);

      // Debug purpose only
      Console.WriteLine(card.cardString);  
    }