c# 字典和forloop/写入文本搞砸了 - 如何让它通过一次而不是通过每次迭代

Question

    using System;
using System.IO;
using System.Collections.Generic;
using System.Threading;
using System.Diagnostics;

namespace ConsoleApplication9
{
    class main
    {
        private static StreamWriter objWriter = new StreamWriter(@"D:\text1.txt", true);
        private static StreamWriter tripWriter = new StreamWriter(@"D:\text2.txt", true);

        private static void Main()
        {
            WelcomeMenu();
        }
        public static void WelcomeMenu()
        {
            Console.WriteLine("Welcome to Pow Drop Log v1");
            Console.WriteLine("A. Press A to start the trip");
            while (true)
            {
                string enteredWelcome = Console.ReadLine();
                {
                    if (enteredWelcome == "a")
                    {
                        List();
                    }
                    else
                    {
                        Console.WriteLine("That is an invalid option");
                        continue;
                    }
                }

            }
        }
        public static void WriteToTextFile(string text)
        {
            objWriter.Write(text);
            objWriter.Flush();
        }
        public static void WriteToCurrentTrip(string text)
        {
            tripWriter.Write(text);
            tripWriter.Flush();
        }
        public static void List()
        {
            Stopwatch Triptime = new Stopwatch();
            Triptime.Start();
            Console.WriteLine("You have started the trip");
            Dictionary<string, string> tdItems = new Dictionary<string, string>();
            tdItems.Add("1", "foo");
            tdItems.Add("2", "bar");
            tdItems.Add("3", "bar");
            tdItems.Add("4", "end");
            while (true)
            {
                string[] items = Console.ReadLine().Split(' ');
                string result = null;
                int result1;
                TimeSpan timeSpan = Triptime.Elapsed; string time = string.Format("{0:00}:{1:00}:{2:00}", timeSpan.Hours, timeSpan.Minutes, timeSpan.Seconds);
                foreach (string itemNumber in items)
                {
                    if (tdItems.ContainsKey(itemNumber) && (int.TryParse(itemNumber, out result1)))
                    {
                        result += " + " + tdItems[itemNumber];
                        WriteToTextFile(tdItems[itemNumber] + Environment.NewLine);
                        WriteToCurrentTrip(tdItems[itemNumber] + Environment.NewLine);
                    }
                    if (!tdItems.ContainsKey(itemNumber) && (int.TryParse(itemNumber, out result1)))
                    {
                        Console.WriteLine("You have entered a drop which is not in the database, Try again");
                        continue;
                    }
                    else if (itemNumber == "end")
                    {
                        Triptime.Stop();
                        Console.WriteLine("End of Trip");
                        Console.WriteLine("Elapsed time " + time);
                        Console.WriteLine("");
                        Console.WriteLine("");
                        Console.WriteLine("");
                        Console.WriteLine("");
                        WelcomeMenu();
                        break;
                    }

                }

            }
        }
    }
}

代码似乎是遍历每个部分而不是一次。

假设我在控制台中输入 1 2 3，它会在文本文件中写入

富 富吧 富吧巴兹 而不是一开始就写 foo + bar + baz。

我调试了它，它显示它一直在运行，我该如何解决这个问题并让它正确运行？

谢谢！

Answer 1

这段代码很糟糕，我建议基本上重写它，直到它更短更简单。但是，如果我必须做出最小的改变来让它打印出正确的东西，我会改变这个：

WriteToTextFile(result.Substring(3) + Environment.NewLine);
WriteToCurrentTrip(result.Substring(3) + Environment.NewLine);

到这里：

WriteToTextFile(tdItems[itemNumber] + Environment.NewLine);
WriteToCurrentTrip(tdItems[itemNumber] + Environment.NewLine);

编辑：作为参考，这大致是我如何写你表示你希望你的List 函数做的事情，与 cmets 交错。你可以让它变得更好，但这应该向你展示一些有用的东西。我希望我的预期行为正确。

// StartNew happens to be a quicker way to create and initialize a Stopwatch

Stopwatch triptime = Stopwatch.StartNew();
Console.WriteLine("You have started the trip");

// you can use collection initializer syntax to make it nicer to read when
// you want to add lots of things to a data structure

var tdItems = new Dictionary<string, string> {
    { "1", "foo" },
    { "2", "bar" },
    { "3", "baz" },
    { "4", "end" },
};

while (true)
{
    string[] items = Console.ReadLine().Split(' ');

    // you can use format strings to easily customize the stringification
    // of DateTime and TimeSpan objects, see the MSDN docs

    string time = string.Format("{0:c}", triptime.Elapsed);

    List<string> waypoints = new List<string>();

    // it's easiest to first find the destinations your trip has to visit

    foreach (string itemNumber in items)
    {
        if (tdItems.ContainsKey(itemNumber))
            waypoints.Add(tdItems[itemNumber]);
        else
            Console.WriteLine(
              "You have entered a drop which is not in the database...");
    }

    // string.Join is an easy way to avoid worrying about putting an extra
    // "+" at the front or end

    string tripDescription = string.Join(" + ", waypoints);

    // "using" is generally important so you don't hold a lock on the file
    // forever, and it saves you from manually calling "flush" -- it
    // flushes when the writers are disposed at the end of the using block

    using (var objWriter = new StreamWriter(@"D:\text1.txt", true))
    using (var tripWriter = new StreamWriter(@"D:\text2.txt", true))
    {
        // WriteLine adds a newline for you

        objWriter.WriteLine(tripDescription);
        tripWriter.WriteLine(tripDescription);
    }

    if (waypoints.Contains("end"))
    {
        Console.WriteLine("End of Trip");
        Console.WriteLine("Elapsed time " + time);
        Console.WriteLine("");
        Console.WriteLine("");
        Console.WriteLine("");
        Console.WriteLine("");
        break;
    }
}

// you'll get the welcome menu again when you return from this function

如果您将代码正在执行的操作分解为小的、可检查的块，则更容易理解、验证和调试。在我的版本中，您可以看到它获得了正确的航点；然后您可以看到描述看起来正确；然后你可以看到它写入了文件。在你的情况下，它有点试图同时做所有事情，所以更难处理。