在 Unity 中重新加载原型不会正确减少弹药和子弹

Question

所以我是 C# 的新程序员（我知道这很令人震惊），我尝试在 Unity 中制作一个重新编码系统的原型，但只是在 Unity 中使用声音和仪表。

问题是当我重新加载时，它并没有正确减少弹药。因为我这样做是为了在你还剩下子弹的情况下重新加载时，它只会从子弹中减去弹药，我已经必须实现它只会减去一个 if (shots == 0)

在我遇到一些问题（另一个令人震惊）并看到我的整个程序只是 if() 语句之后。在重写和重构之后，我仍然有我的问题和 if 语句。我被告知不要发布 200 行代码并且要具体。

我将发布 200 行代码，因为我不知道更好。真的很抱歉。

公共类镜头：MonoBehaviour {

//"CoolDown" is used to limit rate of fire of my gun
public int CoolDown = 5;

//used to prevent shooting while realoding
public int ReloadCoolDown;
public bool IsReloading = false;

//obvious
public int Shots = 0;
public int TotalShots;
public int Magazine = 25;
public int Ammo = 125;
public bool NoAmmo = false;



void Start() 
{
    ReloadCoolDown = 150;
}

void Update()
{
    //Checks if ammo is still present
    CheckForAmmo();
    //just so i could test some stuff faster, can be ignored
    Skip();
    //Also checks for ammo
    if(!NoAmmo)
    {
        GameShot();
        ReloadEmpty();
        ReloadHalf();
        if (IsReloading == true)
        {
            ReloadCoolDown--;
        }
        if (CoolDown <= 0)
        {
            CoolDown = 0;
        }
        CoolDown--;
    }
    else if (NoAmmo)
    {
        ExecNoAmo();
    }
}

//Just getting the audio clips from unity
AudioSource GetAudio(int index)
{
   AudioSource[] audio = GetComponents<AudioSource>();
    if (index == 1)
    {
        return audio[0];
    }
    else if (index == 2)
    {
        return audio[1];
    }
    else if (index == 3)
    {
        return audio[2];
    }
    else if (index == 4)
    {
        return audio[3];
    }
    else
        return null;


}

void GameShot()
{
    //Shoots, increases total shots and shots (for that mag), plays audio, sets the cooldown for the next shot, decreases bullets in mag
    if (Input.GetKey(KeyCode.Space) &&
        CoolDown <= 0 && IsReloading == false)
    {
        TotalShots++;
        GetAudio(1).Play();
        CoolDown = 5;
        Shots++;
        Magazine--;
    }
}

//Reloads if every bullet in the magazine has been fired
void ReloadEmpty()
{
    //this and ReloadHalf() is where you can find so many if statements and where most of my code is tangled up...
    //im trying to check for ammo and if the mag is completely empty to trigger the empty reload
    if (Magazine == 0 && Ammo > 0)
    {

        if(Ammo >= 25)
        {
            Magazine = 25;
        }
        else
        {
            Magazine = Ammo; 
        }

        Ammo -= Shots;
        Shots = 0;
        ReloadCoolDown = 130;
        GetAudio(2).Play();

        IsReloading = true;
    }
    if (ReloadCoolDown <= 0)
    {
        ReloadCoolDown = 150;
        IsReloading = false;
    }
}
void ReloadHalf()
{
    //Again, many if statements and entaglement...
    if ((Input.GetKeyDown(KeyCode.R) && Magazine < 26) && Ammo > 0)
    {
        if (Shots == 0)
            Ammo -= 1;
        ReloadCoolDown = 80;
        GetAudio(3).Play();
        if(Ammo >= 25)
        { 
            Magazine = 26;
            Ammo -= Shots;
        }
        else if (Ammo <= 25)
        {
            Magazine += Ammo;
            if(Magazine > 26)
            {
                int i = Magazine - 25;
                Ammo = i;
                Magazine = 26;
            }

        }
        Shots = 0;
        IsReloading = true;
    }
    if (ReloadCoolDown <= 0)
    {
        ReloadCoolDown = 100;
        IsReloading = false;
    }
}

void ExecNoAmo()
{
    //plays no ammo sound if ammo == 0
    if(Input.GetKeyDown(KeyCode.Space) || Input.GetKeyDown(KeyCode.R))
        GetAudio(4).Play();

}

void CheckForAmmo()
{
    if (Ammo <= 0 && Magazine <= 0)
        NoAmmo = true;
}

void Skip()
{
    if (Input.GetKeyDown(KeyCode.Z))
    {
        Ammo = 25;
    }
}

}

Answer 1

你的反子弹方法很少见。我把我的方法留在这里，以防它对某人有用

（数值示例）

    bulletsTotal = 30;
    bulletsMagazine = 15;
    bulletsMagazineSize = 15;

关于更新方法

if (Input.GetKey(KeyCode.R))
        {
            if(bulletsMagazine!= 15)
            {   
                if (bulletsTotal > 0)
                {
                    asGun.clip = reload;
                    asGun.Play();
                    Reloadgun();
                } 
            }
        }

这就是重新加载的功能

public void Reloadgun()
    {
        int bulletToReload= bulletsMagazineSize-bulletsMagazine;

        if(bulletToReload< bulletsTotal)
        {
            bulletsTotal = bulletsTotal - bulletToReload;
            bulletsMagazine = bulletsMagazine + bulletToReload;
        }
        else
        {
            bulletsMagazine = bulletsMagazine + bulletsTotal;
            bulletsTotal = 0;

        }

        bulletsTxt.text = "M92\n   " + (bulletsMagazine) + "/" + bulletsTotal;
    }

Answer 2

我已经尝试重构您的代码，但问题是您尝试做的事情太多，您应该将关注点分开并将其拆分为几个类。

我创建了新的 PlayerSounds 类，其中包含在您的代码中播放声音的方法，但我懒得完全重构它，因此您的代码逻辑仍然在一个类中，尽管它应该分为 3 个类，一个管理射击，一个管理重新加载，一个管理弹药和杂志。此外，我对重新加载的逻辑完全感到困惑，所以我完全改变了，这将取决于你的需要。

我所做的事情：在某种程度上移除了幻数，它们被改为常量。删除了 NoAmmo、IsReloading、Shots 字段。删除了所有 cmets，任何方法和字段都应该是不言自明的。反向否定条件 - 它们更难阅读。

我也完全改变了重新加载的逻辑，我觉得你想多了，一些 if 语句总是错误的所以我删除了它们，我还将数字 25 和 26 更改为常量，我不明白你为什么需要根据射击次数减去弹药，而你所要做的只是填满弹匣，所以我简化了它。更改它以适合您的需要。 看完代码你甚至可能会发现，这两种重装方法几乎相同，可以合二为一，消除 if 语句，并根据重装子弹的数量播放声音。

去掉 if 就是让方法按照你的意图去做正在做。

class PlayerSounds
    {
        private const int PlayerShootingSound = 0;
        private const int PlayerReloadingMagazineSound = 1;
        private const int PlayerReloadingHalfOfMagazineSound = 2;
        private const int PlayerHasNoAmmoSound = 3;
        private AudioSource[] audio;

        public PlayerSounds(AudioSource[] audio)
        {
            if (audio == null)
                throw new ArgumentNullException(nameof(audio));

            this.audio = audio;
        }

        public void PlayerShot()
        {
            audio[PlayerShootingSound].Play();
        }

        public void PlayerReloadingMagazine()
        {
            audio[PlayerReloadingMagazineSound].Play();
        }

        public void PlayerRealodingHalfMagazine()
        {
            audio[PlayerReloadingHalfOfMagazineSound].Play();
        }

        public void PlayerHasNoAmmo()
        {
            audio[PlayerHasNoAmmoSound].Play();
        }
    }

还有你的 Shot 类：

public class Shot : MonoBehaviour
{
    private const int MagazineSize = 25; // to remove magic number 25 and 26, also to give this number a meaning
    private PlayerSounds playerSounds;

    public int CoolDown = 5;
    public int ReloadCoolDown;
    public int Shots = 0;
    public int TotalShots;
    public int Magazine = 25;
    public int Ammo = 125;

    void Start()
    {
        ReloadCoolDown = 150;
        playerSounds = new PlayerSounds(GetComponents<AudioSource>());
    }

    void Update()
    {
        if (playerTryingToFire())
        {
            tryToShoot();
            playNoAmmoSoundWhenWithoutAmmo();
        }
        else if (playerTryingToReload())
        {
            tryToReloadHalfMagazine();
            playNoAmmoSoundWhenWithoutAmmo();
        }

        tryToReloadEntireMagazine();

        if (CoolDown > 0) CoolDown--;
        if (ReloadCoolDown > 0) ReloadCoolDown--;
    }

    bool playerTryingToFire()
    {
        return Input.GetKey(KeyCode.Space);
    }

    bool playerTryingToReload()
    {
        return Input.GetKeyDown(KeyCode.R);
    }

    void tryToShoot()
    {
        if (playerCanFire())
        {
            TotalShots++;
            playerSounds.PlayerShot();
            CoolDown = 5;
            Magazine--;
        }
    }

    bool playerCanFire()
    {
        return CoolDown == 0 && ReloadCoolDown == 0 && Magazine > 0;
    }

    void playNoAmmoSoundWhenWithoutAmmo()
    {
        if (!hasAmmo())
        {
            playerSounds.PlayerHasNoAmmo();
        }
    }

    void tryToReloadHalfMagazine()
    {
        if (magazineIsNotFull() && hasAmmo())
        {
            int missingBulletCountInMagazine = MagazineSize - Magazine;
            transferAmmoToMagazine(missingBulletCountInMagazine);
            ReloadCoolDown = 80;
            playerSounds.PlayerRealodingHalfMagazine();
        }
    }

    private bool magazineIsNotFull()
    {
        return Magazine < MagazineSize;
    }

    void tryToReloadEntireMagazine()
    {
        if (Magazine == 0 && hasAmmo())
        {
            transferAmmoToMagazine(MagazineSize);
            ReloadCoolDown = 130;
            playerSounds.PlayerReloadingMagazine();
        }
    }

    private void transferAmmoToMagazine(int maximumAmountToFitMagazine)
    {
        int possibleBulletCountToFit = Math.Min(Ammo, maximumAmountToFitMagazine);
        Magazine += possibleBulletCountToFit;
        Ammo -= possibleBulletCountToFit;
    }

    bool hasAmmo()
    {
        return Ammo > 0;
    }
}