代码返回程序的其他方法？

Question

背景：

我试图为一个巨大的电子表格构建一个错误（查找拼写错误等）指示器，根据不同的标准在每一列中发现错误，但通常代码的每个部分（程序？）使用如果发现错误，则循环 if 语句，代码将转到 (goto) 错误列表，这是一个应该将错误及其单元格制成表格的过程。

问题：

Goto 不会像我想象的那样运行，最后的巨大 if 语句不会返回到代码中，并且代码在第一个错误被列表后停止运行，可以做些什么来解决这个问题，因为我想要代码回到程序，我确定我的编码是问题所在，并且 goto 语句能够在代码中出现，这就是为什么我会提到整个冗长且老实说是混乱的代码，这样如果有人能抓住问题。 请关注最后的 if 语句，因为这是问题所在

code: (only a sample including one procedure of many others, this one checks column L for errors)

Sub errorinsight()

    Sheets("sheet1").Activate
    Dim ucolumn As String



    Dim i As Long, j As Long, r As Range
        ' if your data is in a different column then change L to some other letter(s)
ucolumn = "L" 'pick up contr.


For i = 2 To Range(ucolumn & Rows.Count).End(xlUp).Row
        Set r = Range(ucolumn & i)
        If r = MAXXAM Or r = SGS Then
        GoTo nexti1
        Else

        GoTo errorlist
        End If
complink:
nexti1:
        Next i




GoTo mastercodeend

errorlist:

Sheets.Add.Name = "errorsheet" & Format(Now, "yyyy_mm_dd ss_nn_hh")

    Dim counter As Integer, xerror As Range, yerror As Range

    counter = 1
    Set xerror = Range("a" & counter)
    xerror = ucolumn & i
     Set yerror = Range("b" & counter)
     yerror = r
     counter = counter + 1
      ElseIf ucolumn = "L" Then
     GoTo complink
         Else
         End If
    mastercodeend:
    End Sub

Answer 1

最好的办法是使用一些子例程和/或函数来划分代码。正如您所观察到的，使用或过度使用 GoTo 语句会变得一团糟。

Sub errorinsight()
    Dim i As Long, j As Long, r As Range
    Dim ucolumn As String
    Dim counter As Integer: counter = 0

    Sheets("sheet1").Activate

    'if your data is in a different column then change L to some other letter(s)
    ucolumn = "L" 'pick up contr.

    For i = 2 To Range(ucolumn & Rows.Count).End(xlUp).Row
        Set r = Range(ucolumn & i)
        If Not r = MAXXAM AND Not r = SGS Then
           FlagErrors ucolumn, r, counter + 1
        End If
    Next i
End Sub

Sub FlagErrors(ucolumn as String, i as Long, r as Range, byRef counter as Integer)
    Dim xerror As Range, yerror As Range
    Sheets.Add.Name = "errorsheet" & Format(Now, "yyyy_mm_dd ss_nn_hh")
    Range("A" & counter) = ucolumn & i
    Range("B" & counter) = r
    Sheets("sheet1").Activate

    'I remove this block because it doesn't do anything.
    '  * uColumn is hardcoded as "L" in your procedure above
    '  * samplecodelink is an undefined label in your procedure and will raise an error
    '  * GoTo compLink is unnecessary since this sub will return to the next line in the calling procedure
     'If ucolumn = "A" Then
     'GoTo samplecodelink
     '     ElseIf ucolumn = "L" Then
     'GoTo complink
     '    Else
     '    End If

End Sub