【发布时间】:2017-01-04 08:11:41
【问题描述】:
我正在尝试学习如何将 Pundit 与我的 Rails 4 应用程序一起使用。
我有以下型号:
class User < ActiveRecord::Base
has_one :profile
has_many :eois
end
class Profile < ActiveRecord::Base
belongs_to :user
has_many :projects, dependent: :destroy
end
class Project < ActiveRecord::Base
belongs_to :profile
has_many :eois
end
class Eoi < ActiveRecord::Base
belongs_to :project
belongs_to :user
end
我有一个作用域EoiPolicy :
class EoiPolicy < ApplicationPolicy
class Scope
attr_reader :user, :scope
def initialize(user, scope)
@user = user
@scope = scope
end
def resolve
if user.profile.project.id == @eoi.project_id?
scope.where(project_id: @user.profile.project.id)
elsif user.id == eoi.user_id?
scope.where(user_id: user.id)
else
nil
end
end
end
def index?
user.profile.project.id == @eoi.project_id? or user.id == eoi.user_id?
end
def new?
true
end
def show?
user.profile.project.id == @eoi.project_id? or user.id == eoi.user_id?
end
def edit?
user.id == eoi.user.id?
end
def create?
true
end
def update?
user.id == eoi.user.id?
end
def destroy?
user.id == eoi.user.id?
end
end
在我的EoisController 中,我尝试将范围用于:
def index
# @eois = @project.eois
@eois = policy_scope(Eoi)
# @eois = Eois.find_by_project_id(params[:project_id])
end
然后在我的view/eois/index 中,我尝试使用以下方式显示索引:
<% policy_scope(@user.eois).each do |group| %>
我无法让它工作。错误消息在策略中突出显示了我的范围方法的这一行:
if user.profile.project.id == @eoi.project_id?
对我来说,这看起来是正确的,尽管我仍在努力解决这个问题。任何人都可以看到要完成这项工作需要发生什么,因此如果用户是用户,其个人资料拥有相关项目,则与该项目相关的所有 eois 都是可见的。
否则,如果用户是创建eoi的用户,那么他们创建的所有eois都是可见的?
错误信息说:
undefined method `project' for #<Profile:0x007fa03f3faf48>
Did you mean? projects
projects=
我想知道这是不是因为一个索引会有很多记录,它需要在策略中显示不同的内容才能识别多个记录?
我也试过用:
替换那行if @eoi.project_id == @user.profile.project.id?
虽然这也是错误的并且给了
undefined method `project_id' for nil:NilClass
Did you mean? object_id
我也尝试过制作范围:
def resolve
# cant figure what is wrong with this
if eoi.project_id == user.profile.project.id?
scope.where(project_id: @user.profile.project.id)
else
nil
end
end
但这也是错误的,并给出了这个错误:
undefined local variable or method `eoi' for #<EoiPolicy::Scope:0x007ffb505784f8>
我也试过了:
def resolve
# cant figure what is wrong with this
if @eoi.project_id == user.profile.project.id? or Eoi.project_id == user.profile.project.id?
scope.where(project_id: @user.profile.project.id)
elsif user.id == eoi.user_id?
scope.where(user_id: user.id)
else
nil
end
end
end
def index?
user.profile.project.id == Eoi.project_id? or user.id == Eoi.user_id?
end
但该尝试给出了以下错误消息:
undefined method `project_id' for nil:NilClass
Did you mean? object_id
目前的想法
我认为我需要将更多的用户和范围传递给范围方法。如果我也可以通过项目,那么我可以使范围可参考与意向书相关的项目。
如果我可以让这个工作,那么也许我可以让范围方法为控制器上的索引视图工作:
class Scope
attr_reader :user, :scope
def initialize(user, scope, project)
@user = user
@scope = scope
@project = project
end
end
然后在控制器中:
def index
# @eois = @project.eois
@eois = policy_scope(Eoi, @project)
# authorize @eois
# @eois = Eois.find_by_project_id(params[:project_id])
end
这不起作用,当我尝试时收到一条错误消息,提示该策略
wrong number of arguments (given 2, expected 1)
请帮忙!
下一次尝试
我的下一个尝试是尝试从 [this]Pundit issue 中获取建议,并实施该想法,以了解如何为特定用户获取正确的范围。
在我的 Eoi Policy 中,我将解决方法更改为:
class Scope
attr_reader :user, :scope
def initialize(user, scope) #project
@user = user
@scope = scope
# @project = project
end
def resolve
# if Eoi.project_id == user.profile.project.id? or Eoi.project_id == user.profile.project.id?
if user.id == eoi.projects.profile.user.map(&:id)
scope.joins(eois: :projects).where(project_id: user.profile.projects.map(&:id)).empty?
# if scope.eoi.project_id == user.profile.projects.map(&:id)
# scope.where(project_id: user.profile.projects.map(&:id)).empty?
# scope.where(project_id: user.profile.project.id)
# elsif user.id == eoi.user_id?
# scope.where(user_id: user.id)
else
# nil
end
end
end
然后在我的 eoi 控制器索引操作中,我尝试了这个:
def index
# @eois = @project.eois
# @eois = policy_scope(Eoi, @project)
policy_scope(Eoi).where(project_id: params[:project_id])
# authorize @eois
# @eois = Eois.find_by_project_id(params[:project_id])
end
那也行不通。此尝试的错误消息显示:
undefined local variable or method `eoi' for #<EoiPolicy::Scope:0x007f98677c9cf8>
我对尝试的东西没有想法。任何人都可以找到一种方法来为范围提供正确的输入来进行设置吗?
观察 我注意到 github 上许多使用 Pundit 和范围的 repos 还包括这样的方法:
def scope
Pundit.policy_scope!(user, record.class)
end
该方法是对 Scope 类的补充,并且未显示在 Pundit gem 文档中。如果有必要包括,它有什么作用? 1
重写
我现在浏览了 github 上的 200 多个存储库,以深入了解我应该如何编写策略来实现我的目标。我不知道如何按预期使用 Pundit。
我已经完全改变了我的设置,试图解决我无法理解的问题。我现在有:
Eois 控制器
class EoisController < ApplicationController
def index
@eois = Eoi.by_user_id(current_user.id)
end
end
项目:: Eois 控制器
module Projects
class EoisController < ApplicationController
before_action :get_project
before_action :set_eoi, only: [:edit, :update, :destroy]
# after_action :verify_authorized
def index
@eois = Project.by_user_id(current_user.id).find_by(id: params[:project_id]).try(:eois) || []
end
def show
@eoi = Eoi.find(params[:id])
authorize @eoi
end
def set_eoi
@eoi = EoiPolicy::Scope.new(current_user, params[:project_id]).resolve.find(params[:id])
end
def get_project
@project = Project.find(params[:project_id])
end
Eoi Policy(决定何时显示用户制作的所有 eois)
class EoiPolicy < ApplicationPolicy
class Scope
attr_reader :user, :scope
def initialize(user, scope)
@user = user
@scope = scope
end
def resolve
if scope.present?
Eoi.by_user_id(user.id)
# end
else
[]
end
end
end
def index?
user.profile.project.id == Eoi.project_id? or user.id == Eoi.user_id?
end
def new?
true
end
def show?
record.user_id == user.id || user.profile.project_id == record.project_id
# user.profile.project.id == @eoi.project_id? or user.id == eoi.user_id?
end
def edit?
user.id == eoi.user.id?
end
def create?
true
end
def update?
user.id == eoi.user.id?
end
def destroy?
user.id == eoi.user.id?
end
end
路线
resources :eois
resources :projects do
member do
resources :eois, controller: 'projects/eois
end
当我想显示提交的与项目相关的意向书时,我使用项目意向书政策,当我想展示用户创建的意向书时,我使用意向书政策 - 没有范围。
我很想弄清楚这一点,这样我就可以按照预期的方式使用这个宝石。建议将不胜感激。我确信这种尝试不是 Pundit 的本意——但我不知道如何使用这个 gem,如文档中所示。
我不能使用 policy_scope,因为我需要将 project_id 参数传递到项目 eoi 控制器索引操作的索引操作中。
PaReeOhNos 建议
下面列出了我尝试实施 PareeOhNos 建议的尝试。我不确定我是否理解正确,因为 eois 总是有一个项目 id 和一个用户 id,但也许我没有明白 load_parent 方法在做什么。
在我的 Eois 控制器中,我有:
class EoisController < ApplicationController
before_action :load_parent
before_action :load_eoi, only: [:show, :edit, :update, :destroy]
def index
authorize @parent
@eois = EoiPolicy::Scope.new(current_user, @parent).resolve
end
def show
end
# GET /eois/new
def new
@project = Project.find(params[:project_id])
@eoi = @project.eois.build
@contribute = params[:contribute] || false
@participate = params[:participate] || false
@partner = params[:partner] || false
@grant = params[:grant] || false
@invest = params[:invest] || false
end
# GET /eois/1/edit
def edit
end
# POST /eois
# POST /eois.json
def create
@eoi = Project.find(params[:project_id]).eois.build(eoi_params)
@eoi.user_id = @current_user.id
respond_to do |format|
if @eoi.save
format.html { redirect_to Project.find(params[:project_id]), notice: 'Eoi was successfully created.' }
format.json { render :show, status: :created, location: @project }
else
format.html { render :new }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /eois/1
# PATCH/PUT /eois/1.json
def update
respond_to do |format|
if @eoi.update(eoi_params)
format.html { redirect_to @project, notice: 'Eoi was successfully updated.' }
format.json { render :show, status: :ok, location: @eoi }
else
format.html { render :edit }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# DELETE /eois/1
# DELETE /eois/1.json
def destroy
@eoi.destroy
respond_to do |format|
format.html { redirect_to @project, notice: 'Eoi was successfully destroyed.' }
format.json { head :no_content }
end
end
private
def load_parent
# @parent = (params[:project_id] ? Project.find(params[:project_id] : current_user)
@parent = params[:project_id] ? Project.find(params[:project_id]) : current_user
end
def load_eoi
@eoi = Eoi.find(params[:id])
authorize @eoi
end
在我的 Eoi 政策中,我有:
class EoiPolicy < ApplicationPolicy
class Scope
attr_reader :user, :scope
def initialize(user, scope)
@user = user
@scope = scope
end
def resolve
if scope.is_a?(User)
Eoi.where(user_id: scope.id)
elsif scope.is_a?(Project)
Eoi.where(project_id: scope.id)
else
[]
end
end
end
def index?
record.is_a?(User) || user.profile.project.id == record.project_id
end
def new?
true
end
def show?
record.user_id == user.id || user.profile.project_id == record.project_id
end
def edit?
user.id == eoi.user.id?
end
def create?
true
end
def update?
user.id == eoi.user.id?
end
def destroy?
user.id == eoi.user.id?
end
end
在我的 routes.rb 中,我有:
resources :projects do
member do
resources :eois, shallow: true
resources :eois, only: [:index]
在我的 eois/index 中,我有:
<% @eois.sort_by(&:created_at).in_groups_of(2) do |group| %>
<% group.compact.each do |eoi| %>
<h4><%= link_to eoi.user.full_name %></h4>
<%= link_to 'VIEW DETAILS', eoi_path(eoi), :class=>"portfolio-item-view" %>
<% end %>
<% end %>
在我的 eois/ 节目中,我有:
"test"
当我尝试所有这些时,会加载 eois/index 页面。当我尝试显示特定的 eoi 页面时,我收到一条错误消息:
wrong number of arguments (given 2, expected 0)
错误信息指向授权控制器的@eoi行:
def load_eoi
@eoi = Eoi.find(params[:id])
authorize @eoi
end
如果我将 authorize @eoi 放在 show 操作而不是 load eoi 方法中,也会出现同样的错误。
应用政策有
class ApplicationPolicy
attr_reader :user, :scope
class Scope
def initialize(user, scope)
#byebug
@user = user
# record = record
@scope = scope
end
def resolve
scope
end
end
def index?
false
end
def show?
scope.where(:id => record.id).exists?
end
def create?
false
end
def new?
create?
end
def update?
false
end
def edit?
update?
end
def destroy?
false
end
def scope
Pundit.policy_scope!(user, record.class)
end
下一次尝试
采纳 PaReeOhNos 的建议(复制在上面),我尝试对其进行一些调整以更好地适应我的用例。
现在,我有:
Eoi 控制器
class EoisController < ApplicationController
# before_action :get_project
# before_action :set_eoi, only: [:show, :edit, :update, :destroy]
before_action :load_parent
before_action :load_eoi, only: [:show, :edit, :update, :destroy]
# GET /eois
# GET /eois.json
# def index
# @eois = @project.eois
# # @eois = Eois.find_by_project_id(params[:project_id])
# end
def index
# authorize @parent
@eois = policy_scope(Eoi.where(project_id: params[:project_id]))
# @eois = EoiPolicy::Scope.new(current_user, @parent).resolve
end
# GET /eois/1
# GET /eois/1.json
def show
end
# GET /eois/new
def new
@project = Project.find(params[:project_id])
@eoi = @project.eois.build
@contribute = params[:contribute] || false
@participate = params[:participate] || false
@partner = params[:partner] || false
@grant = params[:grant] || false
@invest = params[:invest] || false
end
# GET /eois/1/edit
def edit
end
# POST /eois
# POST /eois.json
def create
@eoi = Project.find(params[:project_id]).eois.build(eoi_params)
@eoi.user_id = @current_user.id
respond_to do |format|
if @eoi.save
format.html { redirect_to Project.find(params[:project_id]), notice: 'Eoi was successfully created.' }
format.json { render :show, status: :created, location: @project }
else
format.html { render :new }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /eois/1
# PATCH/PUT /eois/1.json
def update
respond_to do |format|
if @eoi.update(eoi_params)
format.html { redirect_to @project, notice: 'Eoi was successfully updated.' }
format.json { render :show, status: :ok, location: @eoi }
else
format.html { render :edit }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# DELETE /eois/1
# DELETE /eois/1.json
def destroy
@eoi.destroy
respond_to do |format|
format.html { redirect_to @project, notice: 'Eoi was successfully destroyed.' }
format.json { head :no_content }
end
end
private
def load_parent
# @parent = (params[:project_id] ? Project.find(params[:project_id] : current_user)
@parent = params[:project_id] ? Project.find(params[:project_id]) : current_user
end
def load_eoi
@eoi = Eoi.find(params[:id])
# authorize @eoi
end
Eoi 政策
class EoiPolicy < ApplicationPolicy
class Scope
attr_reader :user, :scope
def initialize(user, scope)
@user = user
@scope = scope
end
def resolve
# since we send the scoped eois from controller, we can pick
# any eoi and get its project id
# check if the current user is the owner of the project
# if (user.profile.projects.map(&:id).include?(project_id))
# # user is the owner of the project, get all the eois
# scope.all
# end
# #not the owner , then get only the eois created by the user
# scope.where(user_id: user.id)
# end
if scope.is_a?(User)
Eoi.where(user_id: scope.id)
elsif scope.is_a?(Project) && (user.profile.projects.map(&:id).include?(project_id))
project_id = scope.first.project_id
Eoi.where(project_id: scope.id)
else
Eoi.none
end
end
end
def index?
record.is_a?(User) || user.profile.project.id == record.project_id
end
def new?
true
end
def show?
record.user_id == user.id || user.profile.project_id == record.project_id
end
def edit?
user.id == eoi.user.id?
end
def create?
true
end
def update?
user.id == eoi.user.id?
end
def destroy?
user.id == eoi.user.id?
end
end
路线
resources :eois#, only: [:index]
concern :eoiable do
resources :eois
end
resources :projects do
concerns :eoiable
end
索引
<% @eois.sort_by(&:created_at).in_groups_of(2) do |group| %>
<% group.compact.each do |eoi| %>
<h4><%= link_to eoi.user.full_name %></h4>
<%= link_to 'VIEW DETAILS', project_eoi_path(eoi.project, eoi), :class=>"portfolio-item-view" %>
<% end %>
<% end %>
查看
'test'
这不起作用,因为当我导航到一个项目然后尝试呈现具有匹配项目 ID 的 eois 索引时,我得到一个空索引页面,而我的数据库中有 4 条记录应该是渲染。
LEITO 的建议
听从 Leito 的建议,我也试过这个:
Eoi 控制器
class EoisController < ApplicationController
before_action :get_project
before_action :set_eoi, only: [:show, :edit, :update, :destroy]
# before_action :load_parent
# before_action :load_eoi, only: [:show, :edit, :update, :destroy]
# GET /eois
# GET /eois.json
# def index
# @eois = @project.eois
# # @eois = Eois.find_by_project_id(params[:project_id])
# end
def index
# authorize @eois
# authorize @parent
# policy_scope(@project.eois)
@eois = policy_scope(Eoi.where(project_id: params[:project_id]))
# @eois = EoiPolicy::Scope.new(current_user, @parent).resolve
end
# GET /eois/1
# GET /eois/1.json
def show
end
# GET /eois/new
def new
@project = Project.find(params[:project_id])
@eoi = @project.eois.build
@contribute = params[:contribute] || false
@participate = params[:participate] || false
@partner = params[:partner] || false
@grant = params[:grant] || false
@invest = params[:invest] || false
end
# GET /eois/1/edit
def edit
end
# POST /eois
# POST /eois.json
def create
@eoi = Project.find(params[:project_id]).eois.build(eoi_params)
@eoi.user_id = @current_user.id
respond_to do |format|
if @eoi.save
format.html { redirect_to Project.find(params[:project_id]), notice: 'Eoi was successfully created.' }
format.json { render :show, status: :created, location: @project }
else
format.html { render :new }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# PATCH/PUT /eois/1
# PATCH/PUT /eois/1.json
def update
respond_to do |format|
if @eoi.update(eoi_params)
format.html { redirect_to @project, notice: 'Eoi was successfully updated.' }
format.json { render :show, status: :ok, location: @eoi }
else
format.html { render :edit }
format.json { render json: @eoi.errors, status: :unprocessable_entity }
end
end
end
# DELETE /eois/1
# DELETE /eois/1.json
def destroy
@eoi.destroy
respond_to do |format|
format.html { redirect_to @project, notice: 'Eoi was successfully destroyed.' }
format.json { head :no_content }
end
end
private
# def load_parent
# # @parent = (params[:project_id] ? Project.find(params[:project_id] : current_user)
# @parent = params[:project_id] ? Project.find(params[:project_id]) : current_user
# end
# def load_eoi
# @eoi = Eoi.find(params[:id])
# # authorize @eoi
# end
# # Use callbacks to share common setup or constraints between actions.
def set_eoi
@eoi = Eoi.find(params[:id])
end
def get_project
@project = Project.find(params[:project_id])
end
Eoi 政策
def initialize(user, scope)
@user = user
@scope = scope
end
def resolve
if scope.joins(project: :profile).where profiles: { user_id: user }
Eoi.where(project_id: scope.ids)
elsif scope.joins(eoi: :user).where eois: { user_id: user }
Eoi.where(user_id: scope.ids)
else
Eoi.none
end
# since we send the scoped eois from controller, we can pick
# any eoi and get its project id
# check if the current user is the owner of the project
# if (user.profile.projects.map(&:id).include?(project_id))
# # user is the owner of the project, get all the eois
# scope.all
# end
# #not the owner , then get only the eois created by the user
# scope.where(user_id: user.id)
# end
# if scope.is_a?(User)
# Eoi.where(user_id: scope.id)
# elsif scope.is_a?(Project) && (user.profile.projects.map(&:id).include?(project_id))
# project_id = scope.first.project_id
# Eoi.where(project_id: scope.id)
# else
# Eoi.none
# end
end
end
def index?
true
# record.is_a?(User) || user.profile.project.id == record.project_id
end
def new?
true
end
def show?
true
# record.user_id == user.id || user.profile.project_id == record.project_id
end
def edit?
user.id == eoi.user.id?
end
def create?
true
end
def update?
user.id == eoi.user.id?
end
def destroy?
user.id == eoi.user.id?
end
end
路线和视图与上面的尝试相同
这里的问题在于我的控制器中的 get project 方法。对于我试图在特定项目上显示所有 eois 的场景,我需要它。当我试图显示用户的所有 eois 时,我不需要它。
当我保存所有这些并尝试时,项目中的 eois 正确显示。然而,应该向我展示我(作为用户)所有 eois 的 eois(未嵌套在项目中)显示的错误是:
Couldn't find Project with 'id'=
错误消息突出显示“get_project 方法”。
LEITO 的更新建议
接受 Leito 的更新建议,我已经开始了当前的尝试。
在此之前,我想澄清一下,所有 Eois 都将同时具有用户 ID 和项目 ID。我用这张表让用户表达对项目的兴趣。我的目标是让其个人资料拥有该项目的用户查看在该项目上提交的所有 eois。然后,我还希望用户看到他们自己提交的所有 eois(跨所有项目)。
Eoi 政策
def resolve
if scope.joins(project: :profile).where 'profiles.user_id = ? OR eois.user_id = ?', user.id, user.id
Eoi.all
else
Eoi.none
end
Eoi 控制器
def index
@eois = policy_scope(Eoi)
@eois = @eois.where(project_id: params[:project_id]) if params[:project_id]
end
目前,这在查找嵌套在项目 (project/26/eois) 下的 eois 时效果很好。但是,当我尝试执行 eois/index(未嵌套在项目下),我想返回所有用户的 eois 时,我收到一条错误消息:
Couldn't find Project with 'id'=
它突出显示了eoi控制器的这一行:
def get_project
@project = Project.find(params[:project_id])
end
我不确定我现在是否理解解析方法或控制器剔除的想法。我看不出范围线有什么问题,无法查看要尝试更改的内容。
【问题讨论】:
-
请一次一个!第一个是一个简单的错误:您的个人资料没有一个项目,而是多个项目。这就是错误的原因。让我们摆脱那个并专注于您尝试使用
.projects -
您是否更改了您的
application_policy.rb还是专家在您安装它时生成的相同? -
我在帖子末尾添加了申请政策
-
梅尔,那个新错误,仅仅是因为
params[:project_id]是零。它与 Pundit 和政策没有太大关系。 Pundit 的政策关注点是:此用户可以访问哪些 Eoi?。英文响应是:那些属于属于用户的配置文件的项目和属于用户的那些。如果 Eoibelongs_to :user,您缺少用户has_many: eois?你能告诉我们更多关于这种关系的信息吗? -
嗨 Leito,我忘记将 has many eois 关联复制到我上面的用户模型。关联存在于用户模型中。我的数据库中有 5 个 eois,它们都有一个项目 ID 和一个用户 ID。
标签: ruby-on-rails ruby scope pundit