Spring @Controller、@Service 和 @Component 中 @Autowire HttpServletRequest 请求的并发问题

Question

由于我在 httpservletrequest 标头中消耗了大量数据并在服务类的请求属性中设置了很多值，我不确定这是否会导致线程安全问题，我查看了网络是否会导致自动装配 httpservlet 请求线程安全问题，我的意见不一

以下是我自动连接 httpservletrequest 的地方

@RestController
Public class UserController {
 
 @Autowire
 HttpServletRequest httpServletRequest;

 @Autowire
 IAMService iamservice;
 
 @PostMapping("/addUser")
 public String addUser(@RequestBody UserDto userdto){
          return iamservice.addUser(userdto);
 }
}

@Service
Public Class IAMService {

 @Autowire
 HttpServletRequest httpServletRequest;

 @Autowire
 UserDao userDao;

 public String addUser(UserDto userdto){
    Long primaryKey = userDao.save(userdto,httpServletRequest.getHeader("loggedInUserId"));
    httpServletRequest.setAttribute("userPrimaryKey",primaryKey);
    return "User is added successfully";
 }
}

Answer 1

我们不应该@Autowire HttpServletRequest。考虑如下修改您的代码以有效使用请求对象并避免线程安全问题-

@RestController
Public class UserController {

 @Autowire
 IAMService iamservice;
 
 @PostMapping("/addUser")
 public String addUser(@RequestBody UserDto userdto, HttpServletRequest httpServletRequest){
          return iamservice.addUser(userdto, httpServletRequest);
 }
}

@Service
Public Class IAMService {

 @Autowire
 UserDao userDao;

 public String addUser(UserDto userdto, HttpServletRequest httpServletRequest){
    Long primaryKey = userDao.save(userdto,httpServletRequest.getHeader("loggedInUserId"));
    httpServletRequest.setAttribute("userPrimaryKey",primaryKey);
    return "User is added successfully";
 }
}