【发布时间】:2018-11-11 07:31:42
【问题描述】:
我有以下一段 C++ 代码,我正在尝试执行一个例程:
#include <thread>
#include <unistd.h>
#include <sys/wait.h>
#include <memory>
using namespace std;
static void upload(const string url, const string path){ int sync_status;}
int main(){
bool flag = true;
for(int worker_id = 0; worker_id < 1; worker_id++){
int worker_pid = fork();
if (worker_pid == 0){
while (true){
std::unique_ptr<std::thread> uploader(nullptr);
if (flag){ // This block only occurs once inside while loop
flag = false;
string path = "l", url = "k";
// Valgrind reports the next line
uploader = std::make_unique<std::thread>(upload, url, path);
}
int child_id = fork();
if (!child_id){
// Do something
exit(0);
}
waitpid(child_id, NULL, 0);
if(uploader && uploader->joinable()){
uploader->join();
}
}
// Do something
exit(0);
}
}
return 0;
}
但 valgrind 似乎总是将这段代码报告如下:
==16424== 80 bytes in 1 blocks are definitely lost in loss record 2 of 2
==16424== at 0x4C3017F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==16424== by 0x10AA39: std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> > std::thread::_S_make_state<std::thread::_Invoker<std::tuple<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >(std::thread::_Invoker<std::tuple<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&&) (thread:197)
==16424== by 0x10A04A: std::thread::thread<void (&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(void (&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) (thread:126)
==16424== by 0x109A64: std::_MakeUniq<std::thread>::__single_object std::make_unique<std::thread, void (&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(void (&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) (unique_ptr.h:825)
==16424== by 0x109514: main (main.cpp:21)
这次泄漏背后的原因是什么?我认为这是由于exit() 通话,但即使在通话之前加入unique_ptr 也无济于事。
【问题讨论】:
-
该程序很难遵循,因为您使用
std::thread、POSIX 线程和派生新进程(无论如何您似乎立即退出,所以我看不出它的意义)。您似乎也没有真正将upload线程用作线程,因为您启动它然后等待它完成后再执行其他任何操作,因此它并不是真正并行运行,您可以直接调用该函数。我也认为不需要将std::thread包装在智能指针中。 -
这不是最小的。有几行没有做任何事情或荒谬。
-
除了学习如何创建Minimal, Complete, and Verifiable Example,我还推荐你learn how to debug your code。但最重要的是,find a simpler problem。通过删除与您的问题无关的任何内容,您可以越来越缩小范围,直到剩下的唯一代码是重现问题的最简单代码,并且您应该希望确切地知道它发生的时间和地点以及原因。
-
请注意,您可以使用此代码复制相同的内容:pastebin.com/QpbF5aj2
-
除此之外:混合分叉和使用线程是你真的不想做的事情。 linuxprogrammingblog.com/…
标签: c++ multithreading memory-leaks valgrind