【发布时间】:2020-01-25 02:06:57
【问题描述】:
我编写了一个简单的“信封”类,以确保我正确理解 C++11 原子语义。我有一个标题和一个有效负载,作者清除标题,填充有效负载,然后用增加的整数填充标题。这个想法是,阅读器然后可以读取标头,memcpy 出有效负载,再次读取标头,如果标头相同,则阅读器可以假设他们成功复制了有效负载。读者可能会错过一些更新是可以的,但他们不能得到一个撕裂的更新(其中有来自不同更新的字节混合)。只有一个读者和一个作者。
写入器使用释放内存顺序,读取器使用获取内存顺序。
memcpy 是否存在被原子存储/加载调用重新排序的风险?或者负载可以相互重新排序吗?这对我来说永远不会中止,但也许我很幸运。
#include <iostream>
#include <atomic>
#include <thread>
#include <cstring>
struct envelope {
alignas(64) uint64_t writer_sequence_number = 1;
std::atomic<uint64_t> sequence_number;
char payload[5000];
void start_writing()
{
sequence_number.store(0, std::memory_order::memory_order_release);
}
void publish()
{
sequence_number.store(++writer_sequence_number, std::memory_order::memory_order_release);
}
bool try_copy(char* copy)
{
auto before = sequence_number.load(std::memory_order::memory_order_acquire);
if(!before) {
return false;
}
::memcpy(copy, payload, 5000);
auto after = sequence_number.load(std::memory_order::memory_order_acquire);
return before == after;
}
};
envelope g_envelope;
void reader_thread()
{
char local_copy[5000];
unsigned messages_received = 0;
while(true) {
if(g_envelope.try_copy(local_copy)) {
for(int i = 0; i < 5000; ++i) {
// if there is no tearing we should only see the same letter over and over
if(local_copy[i] != local_copy[0]) {
abort();
}
}
if(messages_received++ % 64 == 0) {
std::cout << "successfully received=" << messages_received << std::endl;
}
}
}
}
void writer_thread()
{
const char alphabet[] = {"ABCDEFGHIJKLMNOPQRSTUVWXYZ"};
unsigned i = 0;
while(true) {
char to_write = alphabet[i % (sizeof(alphabet)-1)];
g_envelope.start_writing();
::memset(g_envelope.payload, to_write, 5000);
g_envelope.publish();
++i;
}
}
int main(int argc, char** argv)
{
std::thread writer(&writer_thread);
std::thread reader(&reader_thread);
writer.join();
reader.join();
return 0;
}
【问题讨论】:
-
@Tas 不错,已修复。尽管如此,仍然永远不会中止;)
-
我看不出有什么可以阻止这些重新排序(
try_copy):::memcpy(copy, payload, 5000);auto after = sequence_number.load(std::memory_order::memory_order_acquire);我觉得应该是release?同样,start_writing似乎应该使用acquire。 -
@DavisHerring 哎呀,已修复
-
` = {"ABCDEFGHIJKLMNOPQRSTUVWXYZ"}` 是一个奇怪的初始化。
-
@curiousguy 为什么?就可以完成 ASCII 数学运算?
标签: c++ multithreading thread-safety memory-model stdatomic