分割核心转储

Question

| |0|1|2|3|4|5|6|7|8|9|
|0| | | | | | | | | | |
|1| | | | | | | | | | |
|2| | | | | | | | | | |
|3| | | | | | | | | | |
|4| | | | | | | | | | |
|5| | | | | | | | | | |
|6| | | | | | | | | | |
|7| | | | | | | | | | |
|8| | | | | | | | | | |
|9| | | | | | | | | | |

我正在尝试制作一个看起来像这样的网格。目前，每当我尝试运行可执行文件时，我都会不断转储分段错误核心。编译器也没有显示任何错误。我也不知道如何在网格内打印数字。下面是我目前拥有的代码（只是整个作业的一部分）。非常感谢任何帮助。

void displayBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Player * player)
{
    /* TODO */
    int i,j;
    char grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2];
    for(i = 0; i < BOARD_HEIGHT; i++)
    {
        for(j = 0; j < BOARD_WIDTH; j++)
        {
            grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2] = '|';
            printf("%c", grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2]);
            printf("%s", EMPTY_OUTPUT);
        }
        printf("\n");
    }    
}

BOARD_HEIGHT 和 BOARD_WIDTH 是在头文件中定义的变量。

#ifndef BOARD_H
#define BOARD_H

#include "helpers.h"
#include "player.h"

#define BOARD_WIDTH 10
#define BOARD_HEIGHT 10

typedef enum cell
{
    EMPTY,
    BLOCKED,
    PLAYER
} Cell;

#define EMPTY_OUTPUT " "
#define BLOCKED_OUTPUT "*"

Cell BOARD_1[BOARD_HEIGHT][BOARD_WIDTH];
Cell BOARD_2[BOARD_HEIGHT][BOARD_WIDTH];

typedef enum playerMove
{
    PLAYER_MOVED,
    CELL_BLOCKED,
    OUTSIDE_BOUNDS
} PlayerMove;


void initialiseBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH]);

void loadBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH],
               Cell boardToLoad[BOARD_HEIGHT][BOARD_WIDTH]);

Boolean placePlayer(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Position position);

PlayerMove movePlayerForward(Cell board[BOARD_HEIGHT][BOARD_WIDTH],
                         Player * player);

void displayBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Player * player);

#endif

第二部分在头文件中。

完整的代码可以在这里找到a1

Answer 1

您的错误出现在您索引网格超出数组末尾的行：

grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2] = '|'; // Bug

这一行超出了本地定义的网格数组的末尾：

char grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2];

请注意，grid[][] 的有效索引从 0 到 BOARD_HEIGHT+1，从 0 到 BOARD_WIDTH+1。您的代码在这两个维度上都可以访问。

这会导致堆栈损坏，因此当 displayBoard 函数返回时，它已损坏堆栈并且您会遇到分段错误。删除此行可消除 seg 错误，但代码仍需正常工作。

您应该引用板数组，并使用索引 i 和 j，而不是硬编码的常量。

这是一个工作版本，我索引板数组，将当前单元格值存储在 currentCell 中，然后根据 switch 语句显示它。给定一个用零填充的空板，这将产生以下输出：

scott> gcc -g -ogeraldTest -O0 board.c
scott> geraldTest 
| |0|1|2|3|4|5|6|7|8|9|
|0| | | | | | | | | | |
|1| | | | | | | | | | |
|2| | | | | | | | | | |
|3| | | | | | | | | | |
|4| | | | | | | | | | |
|5| | | | | | | | | | |
|6| | | | | | | | | | |
|7| | | | | | | | | | |
|8| | | | | | | | | | |
|9| | | | | | | | | | |

这是 main() 和 printBoard 的代码，都在 board.c 中。请注意，printBoard 是按值传递板的，但最好通过引用传递它。

    #include <stdio.h>
    #include "board.h"

    void displayBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Player * player)
    {
        int i,j;

        // First display the header at the top.
        printf("| |");
        for(j=0; j<BOARD_WIDTH;j++)
           printf("%d|",j);
        printf("\n");

        for(i = 0; i < BOARD_HEIGHT; i++)
        {
         // Display each row number
         printf("|%d|",i);

        for(j = 0; j < BOARD_WIDTH; j++)
        {
            // Bug: grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2] = '|';
            Cell currentCell = board[i][j];

            switch(currentCell) {
               case BLOCKED:
                  printf("%s",BLOCKED_OUTPUT);
                  break;
               case PLAYER:
                  printf("P");
                  break;
               default:
                  printf("%s",EMPTY_OUTPUT);
                  break;
            }
            printf("|");

            // This code is wrong
            // printf("%c|", grid[BOARD_HEIGHT + 2][BOARD_WIDTH + 2]);
            // printf("%s", EMPTY_OUTPUT);
        }
        printf("\n");
    }
}

    int main(int argc, char ** argv)
    {
      Cell myBoard[BOARD_HEIGHT][BOARD_WIDTH] = {0};
      Player bob = 0;

      displayBoard(myBoard, &bob);
    }

我拿走了你的 board.h 并定义了缺失的类型，以便让它编译。您可以按原样使用自己的标题。

#ifndef BOARD_H
#define BOARD_H

// #include "helpers.h"
// #include "player.h"

#define BOARD_WIDTH 10
#define BOARD_HEIGHT 10

typedef int  Boolean; // Added
typedef int  Player;  // Added
typedef struct {      // Added
          int row;
          int col;
        } Position;

typedef enum cell
{
    EMPTY,
    BLOCKED,
    PLAYER
} Cell;

#define EMPTY_OUTPUT " "
#define BLOCKED_OUTPUT "*"

Cell BOARD_1[BOARD_HEIGHT][BOARD_WIDTH];
Cell BOARD_2[BOARD_HEIGHT][BOARD_WIDTH];

typedef enum playerMove
{
    PLAYER_MOVED,
    CELL_BLOCKED,
    OUTSIDE_BOUNDS
} PlayerMove;


void initialiseBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH]);

void loadBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH],
               Cell boardToLoad[BOARD_HEIGHT][BOARD_WIDTH]);

Boolean placePlayer(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Position position);

PlayerMove movePlayerForward(Cell board[BOARD_HEIGHT][BOARD_WIDTH],
                         Player * player);

void displayBoard(Cell board[BOARD_HEIGHT][BOARD_WIDTH], Player * player);
#endif