布尔比较在应该为真时返回假

Question

这是作业，请注意。我要写一个卡类，deck类，必须有Equals(Deck aDeck)，每8次shuffle要完美匹配原deck，打印20次迭代。我有我的洗牌工作 - 第 8 次和第 16 次洗牌与原始套牌相同，但 Equals 类一直返回错误。我错过了一些东西并且一直在研究这个 - 任何人都可以指导我解决我的错误吗？提前致谢！

namespace lab2part3
{
    public class DeckOfCards : Card
    {
        const int CARDS = 52;
        private Card[] cards;

        public void Deck()
        {
            cards = new Card[CARDS];
            for (int suitVal = 0; suitVal < 4; suitVal++)
            {
                for (int rankVal = 1; rankVal < 14; rankVal++)
                {
                    cards[suitVal * 13 + rankVal - 1] = new Card((Suit)suitVal, (Rank)rankVal);
                }
            }
        }

        public Card GetCard(int cardNum)
        {
            if (cardNum >= 0 & cardNum <= 51)
                return cards[cardNum];
            else
                throw (new System.ArgumentOutOfRangeException("cardNum", cardNum, "Value must be between 0 and 51."));
        }

        public void Shuffle()
        {
            Card[] newDeck = new Card[CARDS];
            bool[] assigned = new bool[CARDS];
            Random sourceGen = new Random();

            for (int i = 0; i < 52; i++)
            {
                int destCard = 0;
                bool foundCard = false;

                while (foundCard == false)
                {
                    destCard = sourceGen.Next(CARDS);
                    if (assigned[destCard] == false)
                        foundCard = true;
                }
                assigned[destCard] = true;
                newDeck[destCard] = cards[i];
            }
            newDeck.CopyTo(cards, 0);
        }

        public void Faro()
        {
            Card[] firstDeck = new Card[26];
            Card[] secondDeck = new Card[26];
            Card[] finalDeck = new Card[CARDS];

            Array.Copy(cards, 0, firstDeck, 0, 26);
            Array.Copy(cards, 26, secondDeck, 0, 26);

            for (int i = 0, j = 0; i < CARDS; i += 2, j++)
            {
                cards[i] = firstDeck[j];
                cards[i + 1] = secondDeck[j];
            }
        }

        public bool Equals(DeckOfCards other)
        {
            for (int i = 0; i < CARDS; i++)
            {
                if (cards[i] != other[i])
                {
                    return false;
                }
            }

            return true;
        }

        public Card this[int i]
        {
            get { return cards[i]; }
        }
    }
}

-

namespace lab2part3
{
    public class Card
    {
        public enum Suit { H, C, D, S }
        public enum Rank { _A = 1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _J, _Q, _K }
        public Suit suit { get; set; }
        public Rank rank { get; set; }

        public Card(Suit newSuit, Rank newRank)
        {
            suit = newSuit;
            rank = newRank;
        }

        public Card() { }

        public override string ToString()
        {
            StringBuilder s = new StringBuilder(rank.ToString());
            s.Remove(0, 1);
            return (s + "" + suit);
        }

        public bool Equals(Card other)
        {
            return rank == other.rank && suit == other.suit;
        }
    }
}

-

namespace lab2part3
{
    public class CardTester
    {
        public static void Main()
        {
            DeckOfCards MyDeck = new DeckOfCards();
            DeckOfCards CopyDeck = new DeckOfCards();
            Card tempCard = new DeckOfCards();
            MyDeck.Deck();
            CopyDeck.Deck();

            // initial deck setup
            for (int i = 0; i < 52; i++)
            {
                tempCard = MyDeck.GetCard(i);
                Console.Write(tempCard.ToString());

                if (i != 51)
                    Console.Write(", ");
                else
                    Console.WriteLine();

                if (i == 12 || i == 25 || i == 38)
                    Console.WriteLine();
            }

            // 20 looped shuffles

            for (int j = 0; j < 20; j++)
            {
                MyDeck.Faro();
                Console.WriteLine("\nShuffle #" + (j + 1) + ":\n");
                for (int i = 0; i < 52; i++)
                {
                    tempCard = MyDeck.GetCard(i);
                    Console.Write(tempCard.ToString());

                    if (i != 51)
                        Console.Write(", ");
                    else
                        Console.WriteLine();

                    if (i == 12 || i == 25 || i == 38)
                        Console.WriteLine();
                }

                // compare
                Console.WriteLine("does this deck equal the original deck? {0}", CopyDeck.Equals(MyDeck));

                // print original deck
                for (int i = 0; i < 52; i++)
                {
                    tempCard = CopyDeck.GetCard(i);
                    Console.Write(tempCard.ToString());

                    if (i != 51)
                        Console.Write(", ");
                    else
                        Console.WriteLine();

                    if (i == 12 || i == 25 || i == 38)
                        Console.WriteLine();
                }
            }
            Console.ReadKey();
        }
    }
}

Answer 1

您在cards[i] != other[i] 中使用的!= 运算符在与引用类型一起使用时检查引用相等性（除非您显式重载它）。您已经实现了 Card.Equals 方法，请改用它：

for (int i = 0; i < CARDS; i++)
{
    if (!cards[i].Equals(other[i]))
    {
        return false;
    }
}

您应该重写object.Equals 方法，而不是定义新的Equals 方法。 您可以阅读 this 和 this article 以获取有关 C# 中相等性的更多信息。

Answer 2

改变...

public bool Equals(DeckOfCards other)
{
    for (int i = 0; i < CARDS; i++)
    {
        if (cards[i] != other[i])
        {
            return false;
        }
    }

    return true;
}

改为...

public bool Equals(DeckOfCards other)
{
    for (int i = 0; i < CARDS; i++)
    {
        if (!cards[i].Equals(other[i]))
        {
            return false;
        }
    }

    return true;
}

研究覆盖object.Equals的正确方法，以及处理!=等运算符重载

Answer 3

好的，首先，你的 Shuffle 方法非常无效，所以我必须修复它：

public void Shuffle()
        {
            Random sourceGen = new Random();

            for (int i = 0; i < 52; i++)
            {
                Card temp = cards[i];
                int pos = sourceGen.Next(CARDS);
                cards[i] = cards[pos];
                cards[pos] = temp;


            }
        }

至于你的问题，你需要比较2个对象的数据。

for (int i = 0; i < CARDS; i++)
            {
                if (!cards[i].Equals(other[i]))
                {
                    return false;
                }
            }

第三，DeckOfCards 不应该继承自 Card，它们没有关系

第四，方法public void Deck应该是DeckOfCards的构造函数