else 不在 foreach 中执行

Question

我正在尝试编写以下脚本，该脚本会检查文件夹中的一组文件，如果它们存在，请将它们移动到“存档”文件夹。如果没有，请将错误消息写入屏幕和日志文件。

文件移动正常，因此 IF 的第一部分工作正常，但如果没有文件可移动，else 应该启动并输出错误....但事实并非如此。

variables.ps1：

#----- define parameters -----#
#----- Treat All Errors as Terminating -----#
$ErrorActionPreference = "Stop" 
#----- Set count to 0 -----#
$count = 0
#----- get current date ----#
$Now = Get-Date
#----- define amount of days ----#
$Days = "0"
#----- define folder where files are located ----#
$SourceFolder = "C:\HG1\Test\Files"
#----- define folder where files are to be moved to ----#
$DestFolder = "C:\HG1\Test\Files\Archive"
#----- define folder where files are to be moved to ----#
$LogPath = "C:\HG1\archive.log"
#----- define extension ----#
$Extension = "*.log"
#----- define LastWriteTime parameter based on $Days ---#
$LastWrite = $Now.AddDays(-$Days)

#----- get files based on lastwrite filter and specified folder ---#
$Files = Get-Childitem $SourceFolder -Include $Extension -Recurse | Where {$_.LastWriteTime -le "$LastWrite"}

archive_files.ps1

#----- Call variables file variables.ps1 - MUST BE IN SAME LOCATION AS SCRIPT ----#
. ./variables.ps1

foreach ($File in $Files)
    {
    if ($File -ne $NULL)
        {
        move-item -path $File.FullName -destination $DestFolder
        Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: Archived File $File")
        }
    else
        {
        write-host "ERROR: No files to archive" -ForegroundColor "Red"
        Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t ERROR: No files to archive")
        }
    } 
Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: ***Archiving script completed successfully***")

任何帮助将不胜感激。

Answer 1

#----- Call variables file variables.ps1 - MUST BE IN SAME LOCATION AS SCRIPT ----#
. ./variables.ps1


if ($File)
    {
     foreach ($File in $Files)
     {
        move-item -path $File.FullName -destination $DestFolder
        Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: Archived File $File")
     }

    }
else
    {
    write-host "ERROR: No files to archive" -ForegroundColor "Red"
    Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t ERROR: No files to archive")
    }

Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: ***Archive script completed successfully***")

这里，

• Foreach each 不会处理 $null 值 所以如果值不为空，则包含 foreach
• 如果不输入 $null 值，则不需要“-ne $null”

希望这对你有用，

问候，

Kvprasoon

Answer 2

您应该使用Test-Path cmdlet 来检查文件是否存在：

foreach ($File in $Files)
    {
    if (Test-Path $File)
        {
        move-item -path $File.FullName -destination $DestFolder
        Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: Archived File $File")
        }
    else
        {
        write-host "ERROR: No files to archive" -ForegroundColor "Red"
        Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t ERROR: No files to archive")
        }
    } 
Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: ***Archiving script completed successfully***")

Answer 3

你的逻辑倒过来了。

$Files 中的每个 $File 总是something，但$Files 集合本身可能是空的：

if(-not $Files)
{
    foreach($File in $Files)
    {
        Move-Item -Path $File.FullName -Destination $DestFolder
        Add-Content $LogPath -Value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: Archived File $File")
    }
}
else
{
    Write-Host "ERROR: No files to archive" -ForegroundColor "Red"
    Add-Content $LogPath -Value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t ERROR: No files to archive")
}

Add-Content $LogPath -value ("$((Get-Date).ToString('yyyy-MM-dd HH:mm:ss')) `t INFO: ***Archiving script completed successfully***")