如何使用动态表名更新表？

Question

我想更新动态生成的表列。

我试过了

ALTER PROCEDURE [dbo].[spname]
     @Id INT ,
     @Flag varchar(MAX),
     @TableName nvarchar(max) ,  
AS  
BEGIN    
    IF(@Flag='Process')  
    BEGIN   
    DECLARE @squery nvarchar(max) = ''

    IF EXISTS(SELECT NAME FROM [DZ_REPO].SYS.TABLES WHERE NAME = @TABLENAME)
        BEGIN
            set @squery = 'use [DZ_REPO]'
            set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
            A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
            WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'          
            print (@squery)

            set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N'Gender' AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+')  AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')'
        END
    END  
END

但它给出了错误说明

消息 156，级别 15，状态 1，过程 spFileProcess，第 6 行不正确 关键字“AS”附近的语法。消息 102，级别 15，状态 1，程序 spFileProcess，第 26 行“性别”附近的语法不正确。消息 102，级别 15、状态 1、过程 spFileProcess、第 48 行附近的语法不正确 '假'

我编辑

ALTER PROCEDURE [dbo].[spname]
     @Id INT = 1 ,
     @Flag varchar(MAX) = 'Process',
     @TableName nvarchar(max) = 'SONY'  
AS  
BEGIN    
    IF(@Flag='Process')  
    BEGIN   
    DECLARE @squery nvarchar(max) = ''
    print ('call')
    IF EXISTS(SELECT NAME FROM [DZ_REPO].SYS.TABLES WHERE NAME = @TABLENAME)
        BEGIN
            set @squery = 'use [DZ_REPO]'
            print (@squery)
            set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
            A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
            WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'          
            print (@squery)

            set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N'Gender' AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+')  AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')'
        END
    END  
END 

但是没有一个打印被调用并且错误抛出如下

消息 207，级别 16，状态 1，过程 spFileProcess，第 28 行 列名“性别”无效。 消息 207，级别 16，状态 1，过程 spFileProcess，第 30 行 列名“HouseholdIncome”无效。 消息 207，级别 16，状态 1，过程 spFileProcess，第 32 行 列名“PresenceOfChild”无效。

虽然这个 coumn 已经在 mt 表中了

有什么办法吗？

Answer 1

第一个 Update 语句和第二个 Update 语句之间需要空格。

...A.AccountId =('+ @Id+')' and set @squery += 'UPDATE A....

应该改成

...A.AccountId =('+ @Id+')' and set @squery += ' UPDATE A...

如果你在dynamic Sql execution 之前print 将很容易调试。您在中间打印@squery，即使在此之后您要附加更新语句，所以最好在print 上，并在附加所有update statements 后检查。

varchar 列值也应该用single quotes 括起来。

确保将值传递给所有variables，否则@squery 将成为NULL

set @squery = 'use [DZ_REPO]'

set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
            A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
            WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'          
            print (@squery)

 set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
                WHERE A.cGender=B.[Key] 
                AND B.[Column]=N'''Gender''' --Here
                AND A.AccountId = ('+@Id+')

 UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
 WHERE A.cHouseholdIncomeCode=B.[Key] 
 AND B.[Column]=('''+HouseholdIncome+''')  
 AND A.AccountId = ('+@Id+')

 UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
 WHERE A.cPresenceOfChild=B.[Key] 
 AND B.[Column]=('''+PresenceOfChild+''') --here
 AND A.AccountId = ('+@Id+')'

Answer 2

我认为你需要像这样在查询字符串中添加空格

set @squery = 'use [DZ_REPO] '
set @squery += 'UPDATE A SET A.cFirstName......'

然后删除，@TableName nvarchar(max)

Answer 3

用评论检查这个 sql（这是你的第一个 sql 帖子）：

ALTER PROCEDURE [dbo].[spname]
     @Id INT ,
     @Flag varchar(MAX),
     @TableName nvarchar(max),  --remove comma from here
AS  
BEGIN    
    IF(@Flag='Process')  
    BEGIN   
    DECLARE @squery nvarchar(max) = ''

    IF EXISTS(SELECT NAME FROM master.SYS.TABLES WHERE NAME = @TABLENAME)
        BEGIN
            set @squery = 'use [DZ_REPO]'
            set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
            A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
            WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'          
            print (@squery)

            --if 'Gender' id your fixed column then give as below with double comma
            --HouseholdIncome - where you define this variable and assign it
            --PresenceOfChild - where you define this variable and assign it
            set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N''Gender'' AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+')  AND A.AccountId = ('+@Id+')

            UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')'
        END
    END  
END

Answer 4

第一个错误：从@TableName nvarchar(max) 变量的末尾删除逗号(,)。 第二个错误：如果您要在其上传递一些动态值，则需要声明 Gender、HouseholdIncome、HouseholdIncome、PresenceOfChild。或者如果这是列名，则从中删除 +（加号）。

例如： AND B.[Column]=(HouseholdIncome)